Github user steveloughran commented on the issue:

    https://github.com/apache/spark/pull/18111
  
    Not really. I thought about how I could do it, but essentially you do need 
to do things underneath the commit protocol, either in the Hadoop codebase (me) 
or in a test which somehow misconfigured things. It's most likely to surface in 
custom subclasses of `FileOutputCommitter`, so a test would probably consist of 
a run with a new committer set to always return null on `getWorkingPath`, 
verifying the changed assertion went from NPE to an IllegalArgException. 
    
    That's a lot of complexity a test for what is essentially: making explicit 
a requirement of the code, namely, that `getWorkPath.toString()` requires 
`getWorkPath` to be non-null
    
    I've included the before/after stack traces in the JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to