Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/17617#discussion_r118809133
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -251,7 +251,13 @@ class HadoopRDD[K, V](
null
}
// Register an on-task-completion callback to close the input stream.
- context.addTaskCompletionListener{ context => closeIfNeeded() }
+ context.addTaskCompletionListener { context =>
+ // Update the bytes read before closing is to make sure lingering
bytesRead statistics in
+ // this thread get correctly added.
+ updateBytesRead()
--- End diff --
Close can be called in another thread as I remembered, so I added here to
avoid lingering bytesRead in task running thread (Some bytes can be read when
creating InputFormat), also it is no harm to call this `updateBytesRead` again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
