Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118842186
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -711,7 +711,7 @@ nonReserved
| ADD
| OVER | PARTITION | RANGE | ROWS | PRECEDING | FOLLOWING | CURRENT |
ROW | LAST | FIRST | AFTER
| MAP | ARRAY | STRUCT
- | LATERAL | WINDOW | REDUCE | TRANSFORM | USING | SERDE |
SERDEPROPERTIES | RECORDREADER
--- End diff --
I have added as much to the non-reserved keyword list as possible (without
creating ambiguities). The reason for this is that many datasources (for
instance twitter4j) unfortunately use reserved keywords for column names, and
working with these was quite cumbersome. I took the pragmatic approach.
If we want to change this, then we need to do the same Hive did and create
a config flag. We remove them for Spark 3.0...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
