Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18136#discussion_r118855831
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
 ---
    @@ -104,3 +107,25 @@ case class CurrentDatabase() extends LeafExpression 
with Unevaluable {
       override def nullable: Boolean = false
       override def prettyName: String = "current_database"
     }
    +
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_() - Returns a universally unique identifier (UUID) 
string. The value is returned as a canonical UUID 36-character string.",
    +  extended = """
    +    Examples:
    +      > SELECT _FUNC_();
    +       46707d92-02f4-4817-8116-a4c3b23e6266
    +  """)
    +// scalastyle:on line.size.limit
    +case class Uuid() extends LeafExpression with CodegenFallback {
    +  override def foldable: Boolean = true
    --- End diff --
    
    I don't think this function is foldable. If this is foldable, it means we 
might use the same UUID generated by optimizer for all rows.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to