Github user koeninger commented on the issue: https://github.com/apache/spark/pull/18143 Generally looks ok to me, thanks. 2 questions - Did you do any testing on workloads to see if performance stayed the same? Is there a reason not to do the same thing to streaming/kafka010/CachedKafkaConsumer.scala for consistency?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org