Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17723#discussion_r119222097
--- Diff: core/pom.xml ---
@@ -357,6 +357,34 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-crypto</artifactId>
</dependency>
+
+ <!--
+ Testing Hive reflection needs hive on the test classpath only.
--- End diff --
can we workaround it? It's weird to test code of sql module in hive module,
but it's weirder to let sql module depends on hive module. If we can't work
around it, I'd like to move the test to hive module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
