Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17617#discussion_r119517540
  
    --- Diff: 
core/src/test/scala/org/apache/spark/metrics/InputOutputMetricsSuite.scala ---
    @@ -319,6 +319,37 @@ class InputOutputMetricsSuite extends SparkFunSuite 
with SharedSparkContext
         }
         assert(bytesRead >= tmpFile.length())
       }
    +
    +  test("input metrics with old Hadoop API in different thread") {
    +    val bytesRead = runAndReturnBytesRead {
    +      sc.textFile(tmpFilePath, 4).mapPartitions { iter =>
    +        val buf = new ArrayBuffer[String]()
    +        ThreadUtils.runInNewThread("testThread", false) {
    +          iter.flatMap(_.split(" ")).foreach(buf.append(_))
    +        }
    +
    +        buf.iterator
    +      }.count()
    +    }
    +    assert(bytesRead != 0)
    --- End diff --
    
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to