Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18162#discussion_r119533807
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala 
---
    @@ -112,6 +112,12 @@ class TaskMetrics private[spark] () extends 
Serializable {
     
       /**
        * Storage statuses of any blocks that have been updated as a result of 
this task.
    +   *
    +   * Tracking the _updatedBlockStatuses can use a lot of memory.
    +   * It is not used anywhere inside of Spark so we would ideally remove 
it, but its exposed to
    +   * the user in SparkListenerTaskEnd so the api is kept for compatibility.
    +   * By default it is configured to not actually save the block statuses 
via config
    +   * TASK_METRICS_TRACK_UPDATED_BLOCK_STATUSES.
        */
       def updatedBlockStatuses: Seq[(BlockId, BlockStatus)] = {
    --- End diff --
    
    Shall we deprecate it? Considering the cost of collecting this information, 
I think we should not encourage users to use it...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to