Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18158#discussion_r119534247 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -473,7 +474,7 @@ class UtilsSuite extends SparkFunSuite with ResetSystemProperties with Logging { val rawCwd = System.getProperty("user.dir") val cwd = if (Utils.isWindows) s"/$rawCwd".replace("\\", "/") else rawCwd assertResolves("hdfs:/root/spark.jar", "hdfs:/root/spark.jar") - assertResolves("hdfs:///root/spark.jar#app.jar", "hdfs:/root/spark.jar#app.jar") + assertResolves("hdfs:///root/spark.jar#app.jar", "hdfs:///root/spark.jar#app.jar") --- End diff -- I think we do use it in `assert(new URI(Utils.resolveURIs(before)) === new URI(after))`. > different cases of `Utils.resolveURI` I think we should identify the cases. If the only reason is just meant to make the test code prettier but change the existing tests for no reason, I would go -1.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org