Github user bOOm-X commented on a diff in the pull request:
https://github.com/apache/spark/pull/18083#discussion_r119585097
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -111,6 +112,15 @@ private[spark] class LiveListenerBus(conf: SparkConf)
extends SparkListenerBus {
}
}
+ override protected def createTimer(listener: SparkListenerInterface):
Option[Timer] = {
+ if (listener.getClass.getName.startsWith("org.apache.spark")) {
--- End diff --
Why creating listener just for "spark" listener ? We may want timings even
for "third-party" listeners. It is even more important in my mind, for these
listeners because they can be much less optimized and so bring a huge
performance penalty
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
