GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/18187
[SPARK-20967][SQL] SharedState.externalCatalog is not really lazy
## What changes were proposed in this pull request?
`SharedState.externalCatalog` is marked as a `lazy val` but actually it's
not lazy. We access `externalCatalog` while initializing `SharedState` and thus
eliminate the effort of `lazy val`. When creating `ExternalCatalog` we will try
to connect to the metastore and may throw an error, so it makes sense to make
it a `lazy val` in `SharedState`.
## How was this patch tested?
existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark minor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18187
----
commit 7d7331c987d9b15bd2b55efdc76da9d9e6ac078e
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2017-06-02T09:21:34Z
SharedState.externalCatalog is not really lazy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
