Github user yssharma commented on a diff in the pull request:
https://github.com/apache/spark/pull/18029#discussion_r119984045
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala
---
@@ -38,6 +40,7 @@ private[kinesis] class KinesisInputDStream[T: ClassTag](
val endpointUrl: String,
val regionName: String,
val initialPositionInStream: InitialPositionInStream,
+ val initialPositionInStreamTimestamp: Date,
--- End diff --
@budde - I had two approaches in mind while adding this functionality-
1. Additional parameter which can be set by an overloaded method in Builder.
2. Creating a new case class for wrapping initial position with an optional
timestamp.
I went ahead with implementing the first one for backward compatibility
such that users can use their same builders.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
