Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17922#discussion_r119992981
--- Diff: python/pyspark/ml/tests.py ---
@@ -819,6 +847,84 @@ def logistic_regression_check_thresholds(self):
LogisticRegression, threshold=0.42, thresholds=[0.5, 0.5]
)
+ def test_binomial_logistic_regression_bounds(self):
--- End diff --
Usually it's not need to write exactly the same test as Scala in PySpark,
we can use a simple test with loading a dataset or generating a very simple
dataset and run constrained LR on it. You can refer test cases in
[test.py](https://github.com/apache/spark/blob/master/python/pyspark/ml/tests.py)
or other tests like
[this](https://github.com/apache/spark/blob/master/python/pyspark/ml/classification.py#L200).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
