Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r120000387
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1105,19 +1105,26 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
}
/**
- * Create a name LTRIM for TRIM(Leading), RTRIM for TRIM(Trailing), TRIM
for TRIM(BOTH)
+ * Create a function name LTRIM for TRIM(Leading), RTRIM for
TRIM(Trailing), TRIM for TRIM(BOTH),
+ * otherwise, returnthe original funcID.
--- End diff --
nit: `return the original function identifier.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
