Github user adrian-ionescu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18159#discussion_r120129166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -446,7 +450,12 @@ case class DataSource(
dataSource.createRelation(
sparkSession.sqlContext, mode, caseInsensitiveOptions,
Dataset.ofRows(sparkSession, data))
case format: FileFormat =>
-
sparkSession.sessionState.executePlan(planForWritingFileFormat(format, mode,
data)).toRdd
+ val qe =
sparkSession.sessionState.executePlan(planForWritingFileFormat(format, mode,
data))
+ val insertCommand = qe.executedPlan.collect {
+ case w: WrittenFileCommandExec => w
+ }.head
+ insertCommand.cmd.run(sparkSession, insertCommand.children,
+ metricsCallback.getOrElse(_ => ()))
--- End diff --
This looks like a hack and you did it in 3 different places.
There has to be a way to get it to work via `.execute()` and revert this..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
