GitHub user rezasafi reopened a pull request:
https://github.com/apache/spark/pull/18148
[SPARK-20926][SQL] Removing exposures to guava library caused by directly
accessing SessionCatalog's tableRelationCache
There could be test failures because DataStorageStrategy,
HiveMetastoreCatalog and also HiveSchemaInferenceSuite were exposed to guava
library by directly accessing SessionCatalog's tableRelationCacheg. These
failures occur when guava shading is in place.
## What changes were proposed in this pull request?
This change removes those guava exposures by introducing new methods in
SessionCatalog and also changing DataStorageStrategy, HiveMetastoreCatalog and
HiveSchemaInferenceSuite so that they use those proxy methods.
## How was this patch tested?
Unit tests passed after applying these changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rezasafi/spark branch-2.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18148
----
commit 8253bbe36d551f11d8e48ab92444977ac5b0776a
Author: Reza Safi <rezas...@cloudera.com>
Date: 2017-05-30T21:58:39Z
[SPARK-20926][SQL] Removing exposures to guava library through directly
accessing SessionCatalog's tableRelationCache
There were test failures because DataStorageStrategy, HiveMetastoreCatalog
and also HiveSchemaInferenceSuite were exposed to the shaded Guava library.
This change removes those exposures by introducing new methods in
SessionCatalog.
commit 9821ea191d63b327663f29adb04b48c856c550ff
Author: Reza Safi <rezas...@cloudera.com>
Date: 2017-06-02T01:36:05Z
Making tableRelationCache private and updating the comments.
commit 942137299dc03de53ce3e7120ac052f5764c14dc
Author: Reza Safi <rezas...@cloudera.com>
Date: 2017-06-02T03:44:57Z
Fixing scalastyle check errors
commit 2832253afe2a48daae3f78568315b19a5aeb045f
Author: Reza Safi <rezas...@cloudera.com>
Date: 2017-06-02T23:49:49Z
Changing the names for two of the methods.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
