Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17882#discussion_r120352440
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -176,16 +179,6 @@ private[spark] abstract class YarnSchedulerBackend(
       }
     
       /**
    -   * Reset the state of SchedulerBackend to the initial state. This is 
happened when AM is failed
    -   * and re-registered itself to driver after a failure. The stale state 
in driver should be
    -   * cleaned.
    -   */
    -  override protected def reset(): Unit = {
    --- End diff --
    
    Why would you remove this method, AFAIK it is still necessary, otherwise 
who will reset the state of `ExecutorAllocationManager`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to