Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18252#discussion_r121240900
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -399,13 +399,13 @@ object DateTimeUtils {
digitsMilli += 1
}
- if (!justTime && isInvalidDate(segments(0), segments(1), segments(2)))
{
- return None
+ while (digitsMilli > 6) {
--- End diff --
add a comment indicating we are truncating the microsecond part and its
lossy?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
