Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18258
I just ran the existing `AggregateBenchmark` with the new tracking config:
Java HotSpot(TM) 64-Bit Server VM 1.8.0_102-b14 on Linux 4.9.27-moby
Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
Aggregate w keys: Best/Avg Time(ms) Rate(M/s)
Per Row(ns) Relative
------------------------------------------------------------------------------------------------
codegen = F, track = F 10655 / 11043 7.9
127.0 1.0X
codegen = T hashmap = F, track = F 6923 / 7133 12.1
82.5 1.5X
codegen = T hashmap = T, track = F 1325 / 1511 63.3
15.8 8.0X
Java HotSpot(TM) 64-Bit Server VM 1.8.0_102-b14 on Linux 4.9.27-moby
Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
Aggregate w keys: Best/Avg Time(ms) Rate(M/s)
Per Row(ns) Relative
------------------------------------------------------------------------------------------------
codegen = F, track = T 10809 / 11007 7.8
128.9 1.0X
codegen = T hashmap = F, track = T 6581 / 6629 12.7
78.4 1.6X
codegen = T hashmap = T, track = T 1411 / 1552 59.4
16.8 7.7X
Looks like no obvious perf degradation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
