Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121265343
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -518,19 +519,13 @@ private void throwUnsupportedException(int
requiredCapacity, Throwable cause) {
public abstract double getDouble(int rowId);
/**
- * Puts a byte array that already exists in this column.
- */
- public abstract void putArray(int rowId, int offset, int length);
-
- /**
- * Returns the length of the array at rowid.
+ * After writing array elements to the child column vector, call this
method to set the offset and
+ * length of the written array.
*/
- public abstract int getArrayLength(int rowId);
-
- /**
- * Returns the offset of the array at rowid.
- */
- public abstract int getArrayOffset(int rowId);
+ public void arrayWriteEnd(int rowId, int offset, int length) {
--- End diff --
no there is no `arrayWriteStart`.
Maybe I should pick another name, how about `putArrayOffsetAndLength` or
just keep the original name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
