Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18260#discussion_r121306979
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
---
@@ -42,15 +42,13 @@
// Array for each type. Only 1 is populated for any type.
private byte[] byteData;
private short[] shortData;
+ // This is not only used to store data for int column vector, but also
can store offsets and
+ // lengths for array column vector.
private int[] intData;
--- End diff --
Good catch. Is it possible to use `longData`, which has a pair of 32-bit
offset and length, to keep `MAX_CAPACITY` array length?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
