Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18258#discussion_r121317516
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -313,7 +316,7 @@ case class HashAggregateExec(
TaskContext.get().taskMemoryManager(),
1024 * 16, // initial capacity
TaskContext.get().taskMemoryManager().pageSizeBytes,
- false // disable tracking of performance metrics
+ true // tracking of performance metrics
--- End diff --
Yeah, based on the benchmark, seems the performance degradation is not an
issue. We can completely remove this parameter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
