Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18268#discussion_r121320104
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
---
@@ -149,13 +149,30 @@ object SetCommand {
/**
* This command is for resetting SQLConf to the default values. Command
that runs
* {{{
+ * reset key;
* reset;
* }}}
*/
-case object ResetCommand extends RunnableCommand with Logging {
+case class ResetCommand(key: Option[String]) extends RunnableCommand with
Logging {
+
+ private val runFunc: (SparkSession => Unit) = key match {
+
+ case None =>
+ val runFunc = (sparkSession: SparkSession) => {
+ sparkSession.sessionState.conf.clear()
+ }
+ runFunc
+
+ // (In Hive, "RESET key" clear a specific property.)
+ case Some(key) =>
+ val runFunc = (sparkSession: SparkSession) => {
+ sparkSession.conf.unset(key)
+ }
+ runFunc
+ }
override def run(sparkSession: SparkSession): Seq[Row] = {
- sparkSession.sessionState.conf.clear()
+ runFunc(sparkSession)
--- End diff --
Nit: Just use a few lines to implement logics here. No need to add the
extra function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
