Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18281#discussion_r121735342
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
    @@ -101,6 +101,40 @@ class OneVsRestSuite extends SparkFunSuite with 
MLlibTestSparkContext with Defau
         assert(expectedMetrics.confusionMatrix ~== ovaMetrics.confusionMatrix 
absTol 400)
       }
     
    +  test("one-vs-rest: tuning parallelism produces correct output") {
    +    val numClasses = 3
    +    val ova = new OneVsRest()
    +      .setClassifier(new LogisticRegression)
    +      .setParallelism(8)
    +    assert(ova.getLabelCol === "label")
    --- End diff --
    
    No need to check Params.  That's not what this unit test is for.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to