Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/18281
I agree; it'd be good to match on the Param name. Do you think
"parallelism" is too vague? If not, then I like it since it's simple.
I'd vote for default parallelism of 1 to be safe (match current
CrossValidator behavior). We can change this PR to use 1 as well for
uniformity.
Do we really need to expose the ability to pass in an ExecutorService?
Given how few people have requested any kind of parallelism, I have a hard time
imagining people needing to pass in an ExecutorService. If one of you has a
need for it, I guess that's fine, but I'd recommend it be marked as a
DeveloperApi and clearly documented (e.g., not saved by persistence, etc.).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
