Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17865#discussion_r121859623
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -189,15 +210,15 @@ def _():
     }
     
     for _name, _doc in _functions.items():
    -    globals()[_name] = since(1.3)(_create_function(_name, _doc))
    +    globals()[_name] = 
since(1.3)(ignore_unicode_prefix(_create_function(_name, _doc)))
    --- End diff --
    
    Yea, I didn't mean to not use but avoid applying all other docs (more 
specifically the ones in `_functions`).  This basically replaces u prefix via 
regex and rather a workaround IMHO. So, I think we should avoid applying this 
to other doctests not using unicode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to