Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r122050475
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -183,12 +185,38 @@ public void testChildProcLauncher() throws Exception {
assertEquals(0, app.waitFor());
}
+ @Test
+ public void testThreadLauncher() throws Exception {
+ // This test is failed on Windows due to the failure of initiating
executors
+ // by the path length limitation. See SPARK-18718.
+ assumeTrue(!Utils.isWindows());
+
+ launcher = new SparkLauncher();
+ launcher
+ .setMaster("local")
+ .setAppResource(SparkLauncher.NO_RESOURCE)
+ .setConf(SparkLauncher.DRIVER_EXTRA_JAVA_OPTIONS,
+ "-Dfoo=bar -Dtest.appender=childproc")
+ .setConf(SparkLauncher.DRIVER_EXTRA_CLASSPATH,
System.getProperty("java.class.path"))
+ .setMainClass(SparkLauncherTestApp.class.getName())
+ .launchAsThread(true)
+ .addAppArgs("thread");
+ final SparkAppHandle app = launcher.startApplication();
+ sleep(3000);
+ AbstractSparkAppHandle handle = (AbstractSparkAppHandle)app;
+ handle.waitFor();
--- End diff --
In this unit test the main application is Simple application. There is no
spark application running in background to track status, so no way to use
`handle.getState`. All I am checking is for launched thread/process is complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
