Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18231#discussion_r122227418
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -150,27 +150,20 @@ public void registerExecutor(
}
/**
- * Obtains a FileSegmentManagedBuffer from a shuffle block id. We expect
the blockId has the
- * format "shuffle_ShuffleId_MapId_ReduceId" (from ShuffleBlockId), and
additionally make
- * assumptions about how the hash and sort based shuffles store their
data.
+ * Obtains a FileSegmentManagedBuffer from (shuffleId, mapId, reduceId).
We make assumptions
+ * about how the hash and sort based shuffles store their data.
*/
- public ManagedBuffer getBlockData(String appId, String execId, String
blockId) {
- String[] blockIdParts = blockId.split("_");
- if (blockIdParts.length < 4) {
- throw new IllegalArgumentException("Unexpected block id format: " +
blockId);
- } else if (!blockIdParts[0].equals("shuffle")) {
- throw new IllegalArgumentException("Expected shuffle block id, got:
" + blockId);
- }
- int shuffleId = Integer.parseInt(blockIdParts[1]);
- int mapId = Integer.parseInt(blockIdParts[2]);
- int reduceId = Integer.parseInt(blockIdParts[3]);
-
+ public ManagedBuffer getBlockData(
+ String appId,
+ String execId,
+ int shuffleId,
+ int mapId,
+ int reduceId) {
ExecutorShuffleInfo executor = executors.get(new AppExecId(appId,
execId));
if (executor == null) {
throw new RuntimeException(
String.format("Executor is not registered (appId=%s, execId=%s)",
appId, execId));
}
-
--- End diff --
nit: we should keep the original format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
