Github user actuaryzhang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18025#discussion_r122318874
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -85,17 +100,20 @@ setMethod("acos",
                 column(jc)
               })
     
    -#' Returns the approximate number of distinct items in a group
    +#' @section Details:
    +#' \code{approxCountDistinct}: Returns the approximate number of distinct 
items in a group.
     #'
    -#' Returns the approximate number of distinct items in a group. This is a 
column
    -#' aggregate function.
    -#'
    -#' @rdname approxCountDistinct
    -#' @name approxCountDistinct
    -#' @return the approximate number of distinct items in a group.
    +#' @rdname column_aggregate_functions
     #' @export
    -#' @aliases approxCountDistinct,Column-method
    -#' @examples \dontrun{approxCountDistinct(df$c)}
    +#' @aliases approxCountDistinct approxCountDistinct,Column-method
    +#' @examples
    +#'
    --- End diff --
    
    Yes, this newline is needed to separate blocks of examples. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to