Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18309#discussion_r122581751
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
    @@ -126,6 +127,27 @@ private[sql] trait SQLTestUtils
       }
     
       /**
    +   * Creates the requested number of temporary path (without creating the 
actual file/directory),
    +   * which are then passed to f and will be deleted after f returns.
    +   *
    +   * @param num Number of directories to create
    +   * @param f Function to invoke with the created paths
    +   */
    +  protected def withTempPaths(num: Int)(f: List[File] => Unit) {
    +    val paths = mutable.ListBuffer[File]()
    +    for (i <- 0 until num) {
    +      val path = Utils.createTempDir().getCanonicalFile
    +      path.delete()
    --- End diff --
    
    why do we need to delete here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to