Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17862#discussion_r122607391
  
    --- Diff: R/pkg/R/mllib_classification.R ---
    @@ -96,7 +98,8 @@ setClass("NaiveBayesModel", representation(jobj = "jobj"))
     #' @note spark.svmLinear since 2.2.0
     setMethod("spark.svmLinear", signature(data = "SparkDataFrame", formula = 
"formula"),
               function(data, formula, regParam = 0.0, maxIter = 100, tol = 
1E-6, standardization = TRUE,
    -                   threshold = 0.0, weightCol = NULL, aggregationDepth = 
2) {
    +                   threshold = 0.0, weightCol = NULL, aggregationDepth = 
2, solver = "l-bfgs",
    --- End diff --
    
    for parameter with limited choice,
    use `c("l-bfgs", "owlqn")` 
https://github.com/apache/spark/pull/18140/files#diff-2e1e5d49cfda9702645a955f584572eeR129
    and match.arg instead 
https://github.com/apache/spark/pull/18140/files#diff-2e1e5d49cfda9702645a955f584572eeR132


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to