Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18343#discussion_r122636117
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -141,8 +143,8 @@ private[spark] class HighlyCompressedMapStatus private (
         private[this] var numNonEmptyBlocks: Int,
         private[this] var emptyBlocks: RoaringBitmap,
         private[this] var avgSize: Long,
    -    @transient private var hugeBlockSizes: Map[Int, Byte])
    -  extends MapStatus with Externalizable {
    +    @transient private[this] var hugeBlockSizes: Map[Int, Byte])
    +  extends MapStatus with Externalizable with KryoSerializable {
    --- End diff --
    
    I think the previous version already worked...  When we have 
`writeExternal` and `readExternal`, `@transient` doesn't matter for java 
serializer, so removing `@transient` to make it work with kryo is a valid fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to