Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18334#discussion_r122790775
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
 ---
    @@ -161,6 +161,11 @@ case class InsertIntoHadoopFsRelationCommand(
           fileIndex.foreach(_.refresh())
           // refresh data cache if table is cached
           sparkSession.catalog.refreshByPath(outputPath.toString)
    +
    +      if (catalogTable.nonEmpty) {
    +        CommandUtils.updateTableStats(sparkSession, catalogTable.get)
    --- End diff --
    
    It's difficult to get the size of `query` in insert command.
    Besides, I personally prefer simple implementation here, because usually 
the overhead of scanning files is negligible compared to the append operation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to