Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2475#discussion_r18122131
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/avro.scala ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql
+
+import org.apache.avro.Schema
+import org.apache.avro.file.DataFileReader
+import org.apache.avro.generic.{GenericRecord, GenericDatumReader}
+import org.apache.avro.mapred.FsInput
+
+import org.apache.hadoop.fs.Path
+
+import org.apache.spark.sql.foreign._
+import org.apache.spark.sql.test.TestSQLContext
+
+import scala.collection.JavaConversions._
+
+/**
+ * An example of a Spark SQL foreign data source for reading data stored
in Avro. Currently this
+ * is only for illustrative purposes and much of the data type conversion
logic still needs to be
+ * written.
+ */
+package object avro extends DataSource {
--- End diff --
i think it is slightly confusing to make this a package object that extends
DataSource for a few reasons
1. it is less common for a package object to implement a lot of stuff
2. based on the fact that you have an implicit class AvroContext, I'm
assuming users would usually import avro._. in this case, createRelation is
exposed as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
