GitHub user actuaryzhang reopened a pull request:

    https://github.com/apache/spark/pull/18140

    [SPARK-20917][ML][SparkR] SparkR supports string encoding consistent with R

    ## What changes were proposed in this pull request?
    
    Add `stringIndexerOrderType` to `spark.glm` and `spark.survreg` to support 
string encoding that is consistent with default R. 
    
    ## How was this patch tested?
    new tests 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/actuaryzhang/spark sparkRFormula

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18140
    
----
commit aba1429c48580ed19ae0a653830d065c681b7150
Author: actuaryzhang <actuaryzhan...@gmail.com>
Date:   2017-05-28T01:39:51Z

    add stringIndexerOrderType to SparkR glm and test result consistency with R

commit 49e50849ac7566aad9eb251535a29a59b659a68a
Author: actuaryzhang <actuaryzhan...@gmail.com>
Date:   2017-05-30T01:36:39Z

    add stringIndexerOrderType to survreg

commit cdc6c377ada3187111cdf984e8cd595ba78b69dc
Author: actuaryzhang <actuaryzhan...@gmail.com>
Date:   2017-05-30T02:52:22Z

    fix test

commit 18cbeb79b7cbf12a6d77110673312b82edbed92a
Author: actuaryzhang <actuaryzhan...@gmail.com>
Date:   2017-05-30T07:39:49Z

    address comments on doc

commit 6ae4d56592aef607a9e6d29b11fbb703bc4b971c
Author: actuaryzhang <actuaryzhan...@gmail.com>
Date:   2017-05-31T16:50:44Z

    add match arg

commit 3c1b85eb4db97723576927a2f972543c7ae69678
Author: actuaryzhang <actuaryzhan...@gmail.com>
Date:   2017-05-31T18:31:43Z

    add match arg in survreg

commit f33d0eafa5fc2a0b806c7016b42574045c3261af
Author: actuaryzhang <actuaryzhan...@gmail.com>
Date:   2017-06-19T17:08:10Z

    address comments

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to