Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/15821
  
    LGTM, my last concern is 
https://github.com/apache/spark/pull/15821#discussion_r122925584
    
    Ideally an optimization should never change result, can you investigate why 
we have different result for int and float?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to