Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2542#discussion_r18123585
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
 ---
    @@ -110,9 +110,18 @@ abstract class LogicalPlan extends 
QueryPlan[LogicalPlan] with Logging {
             }
     
           if (resolver(option.name, remainingParts.head)) {
    -        // Preserve the case of the user's attribute reference.
    -        (option.withName(remainingParts.head), remainingParts.tail.toList) 
:: Nil
    +        if (remainingParts.length == 1) {
    +          // for simple data type
    +          (option.withName(remainingParts.head), Nil) :: Nil
    +        } else if (option.dataType.isInstanceOf[StructType]) {
    +          // for complex data type
    +          (option.withName(remainingParts.head), 
remainingParts.tail.toList) :: Nil
    +        } else {
    +          // for simple data type but multiple parts remaining
    +          Nil
    +        }
    --- End diff --
    
    Maybe this?
    
    ```scala
    (option.dataType, remainingParts) match {
      // No nesting
      case (_, _ :: Nil) => (option, Nil) :: Nil
      // Points to nested field(s) of a structure
      case (_: StructType, _ :: tail) => (option, tail) :: Nil
      // Invalid
      case _ => Nil
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to