Github user sjbrunst commented on the pull request:
https://github.com/apache/spark/pull/1717#issuecomment-57056007
@ezhulenev I've pulled in your changes and fixed a small scalastyle error.
I agree that we should avoid having too many methods for all the parameter
combinations, but I don't have any experience with making factories so I don't
know how we would implement that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
