Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18162#discussion_r123262316
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
    @@ -528,7 +528,13 @@ class JobProgressListener(conf: SparkConf) extends 
SparkListener with Logging {
             new StageUIData
           })
           val taskData = stageData.taskData.get(taskId)
    -      val metrics = TaskMetrics.fromAccumulatorInfos(accumUpdates)
    +      val accumsFiltered = if 
(conf.get(TASK_METRICS_TRACK_UPDATED_BLOCK_STATUSES)) {
    +        accumUpdates
    +      } else {
    +        accumUpdates.filter(info => info.name.isDefined && 
info.update.isDefined && info.name !=
    --- End diff --
    
    yes that is correct as I said it shouldn't really ever get there so I can 
add an assert.  Sorry for the delay was out of office for a while. I'll update 
it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to