Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r123415688
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -258,23 +256,7 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
if (mainClass == null && SparkSubmit.isUserJar(primaryResource)) {
SparkSubmit.printErrorAndExit("No main class set in JAR; please
specify one with --class")
}
- if (driverMemory != null
- && Try(JavaUtils.byteStringAsBytes(driverMemory)).getOrElse(-1L)
<= 0) {
- SparkSubmit.printErrorAndExit("Driver Memory must be a positive
number")
- }
- if (executorMemory != null
- && Try(JavaUtils.byteStringAsBytes(executorMemory)).getOrElse(-1L)
<= 0) {
- SparkSubmit.printErrorAndExit("Executor Memory cores must be a
positive number")
- }
- if (executorCores != null && Try(executorCores.toInt).getOrElse(-1) <=
0) {
- SparkSubmit.printErrorAndExit("Executor cores must be a positive
number")
- }
- if (totalExecutorCores != null &&
Try(totalExecutorCores.toInt).getOrElse(-1) <= 0) {
- SparkSubmit.printErrorAndExit("Total executor cores must be a
positive number")
- }
- if (numExecutors != null && Try(numExecutors.toInt).getOrElse(-1) <=
0) {
- SparkSubmit.printErrorAndExit("Number of executors must be a
positive number")
- }
--- End diff --
The above changes are valid and useful, I'd suggest to not change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
