Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15417#discussion_r123422222
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
---
@@ -55,6 +55,14 @@ trait AnalysisTest extends PlanTest {
comparePlans(actualPlan, expectedPlan)
}
+ protected override def comparePlans(
+ plan1: LogicalPlan,
+ plan2: LogicalPlan,
+ checkAnalysis: Boolean = false): Unit = {
+ // Analysis tests may have not been fully resolved, so skip
checkAnalysis.
--- End diff --
this comment explains why we set the default value of `checkAnalysis` to
false, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
