Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18378#discussion_r123425404
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1721,7 +1721,14 @@ def toPandas(self):
             1    5    Bob
             """
             import pandas as pd
    -        return pd.DataFrame.from_records(self.collect(), 
columns=self.columns)
    +
    +        dtype = {}
    +        for field in self.schema:
    +            pandas_type = _to_corrected_pandas_type(field.dataType)
    +            if (pandas_type):
    +                dtype[field.name] = pandas_type
    +
    +        return pd.DataFrame.from_records(self.collect(), 
columns=self.columns).astype(dtype)
    --- End diff --
    
    The param `copy` of `astype` is true by default. Seems to me we don't need 
copying the data?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to