Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -366,7 +366,7 @@ class SqlParser extends StandardTokenParsers with
PackratParsers {
case base ~ _ ~ ordinal => GetItem(base, ordinal)
} |
(expression <~ ".") ~ ident ^^ {
- case base ~ fieldName => GetField(base, fieldName)
+ case base ~ fieldName => UnresolvedGetField(base, fieldName)
--- End diff --
Instead of creating a new type of `GetField`, can we just use the
`resolved` field in the existing one determine when the rule needs to take
action?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
