Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18362#discussion_r123433849
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala 
---
    @@ -158,6 +158,8 @@ private[deploy] object DeployMessages {
     
       case class ApplicationRemoved(message: String)
     
    +  case class WorkerRemoved(id: String, host: String, message: String)
    --- End diff --
    
    There are some overlap but not quite straight forward, I can remove some of 
the SlaveLost(...workerLost) messages as a followup work.
    But for this PR, I'd like to keep the scope to only add a new message type 
and don't change the existing messages, to make the review easier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to