Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18329#discussion_r123440074
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -264,12 +281,12 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
df,
sink,
outputMode,
- useTempCheckpointLocation = true,
+ useTempCheckpointLocation = isTempCheckpointLocationAvailable,
trigger = trigger)
} else {
val (useTempCheckpointLocation, recoverFromCheckpointLocation) =
if (source == "console") {
- (true, false)
+ (isTempCheckpointLocationAvailable, false)
--- End diff --
@jerryshao whether `useTempCheckpointLocation` is `true` or `false` is
still based on the type of Sink, but there is an additional constraint: the
`defaultFs` must be the same as the `tmpFs`. This is the reason of this patch.
Indeed, otherwise the metadata whose path is based on the checkpoint directory
will be tried to be created on `defaultFs`.
If it is different from the `tmpFs`, you get a `PermissionDenied` exception
which is actually caused by the fact that the temp dir is created on the
`tmpFs` and not on the `defaultFs`. With this PR, instead, you will get an
`AnalysisException` telling you to set a `checkpointLocation`, which is a much
more meaningful exception, easy to understand and to fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
