Github user bdrillard commented on the issue:
https://github.com/apache/spark/pull/18377
@sameeragarwal @cloud-fan If I understand well what you mean by
affect/regress, this patch would induce no change at all on the code generated
for any class below the 1600k limit. For such classes smaller than the limit,
all functions are inlined to the
[`OuterClass`](https://github.com/apache/spark/pull/18377/files#diff-8bcc5aea39c73d4bf38aef6f6951d42cR226),
which the
[`declareAddedFuctions`](https://github.com/apache/spark/pull/18377/files#diff-8bcc5aea39c73d4bf38aef6f6951d42cR320)
method now references. Structurally, there would be no change to classes with
code generated below the threshold. I don't know if this explanation suffices
to address your concerns, but I'd say the patch is pretty passive in that code
generation is only affected for cases over the 1600k threshold.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
