Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123630463
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/tablesample-negative.sql ---
@@ -0,0 +1,13 @@
+-- Negative testcases for tablesample
+CREATE DATABASE mydb1;
+USE mydb1;
+CREATE TABLE t1 USING parquet AS SELECT 1 AS i1;
+
+-- Negative tests: negative percentage
+SELECT mydb1.t1 FROM t1 TABLESAMPLE (-1 PERCENT);
--- End diff --
Add a comment in the test case to explain the SQL API always assume
`withReplacement` is set to `false`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
