Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/18364#discussion_r123638453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -152,17 +152,21 @@ object TimeWindow {
}
/**
- * Expression used internally to convert the TimestampType to Long without
losing
+ * Expression used internally to convert the TimestampType to Long and
back without losing
* precision, i.e. in microseconds. Used in time windowing.
*/
-case class PreciseTimestamp(child: Expression) extends UnaryExpression
with ExpectsInputTypes {
- override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType)
- override def dataType: DataType = LongType
+case class PreciseTimestampConversion(
+ child: Expression,
+ fromType: DataType,
--- End diff --
Maybe we shouldn't be using it then? This is a purely internal expression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
