Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r123675948
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -271,17 +274,40 @@ object OneVsRestModel extends
MLReadable[OneVsRestModel] {
@Since("1.4.0")
final class OneVsRest @Since("1.4.0") (
@Since("1.4.0") override val uid: String)
- extends Estimator[OneVsRestModel] with OneVsRestParams with MLWritable {
+ extends Estimator[OneVsRestModel] with OneVsRestParams with
ParallelismParam with MLWritable {
+
+// /**
+// * param for the number of processes to use when running parallel one
vs. rest
+// * The implementation of parallel one vs. rest runs the classification
for
+// * each class in a separate process.
+// * @group param
+// */
+// @Since("2.3.0")
+// val parallelism = new IntParam(this, "parallelism",
+// "the number of processes to use when running parallel one vs. rest",
ParamValidators.gtEq(1))
+//
+// setDefault(
+// parallelism -> 1
+// )
--- End diff --
need to remove this and other comment blocks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
