Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18288#discussion_r123718043
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMRelation.scala ---
@@ -91,12 +91,10 @@ private[libsvm] class LibSVMFileFormat extends
TextBasedFileFormat with DataSour
val numFeatures: Int = libSVMOptions.numFeatures.getOrElse {
// Infers number of features if the user doesn't specify (a valid)
one.
val dataFiles = files.filterNot(_.getPath.getName startsWith "_")
- val path = if (dataFiles.length == 1) {
- dataFiles.head.getPath.toUri.toString
- } else if (dataFiles.isEmpty) {
+ val path = if (dataFiles.isEmpty) {
throw new IOException("No input path specified for libsvm data")
} else {
- throw new IOException("Multiple input paths are not supported for
libsvm data.")
+ dataFiles.map(_.getPath.toUri.toString).mkString(",")
--- End diff --
+1 @facaiy I think the current fix may scan all input files which is
time-consuming and unnecessary. The original semantics should be advising users
to set ```numFeatures``` if there are multiple input files. So update the error
message should be the correct fix. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
